-
Notifications
You must be signed in to change notification settings - Fork 50
feat: migrate releases to Nx version plans and new decoupled release flow #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
e7ffdaf to
1bf0081
Compare
dbb5bff to
0b2872d
Compare
0b2872d to
2815452
Compare
e519074 to
4ec0665
Compare
4ec0665 to
d46d7fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no longer needed - we use nx release plan:check
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| react-shadow: patch | |||
| --- | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "type": "none", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
fdf9205 to
54c87e1
Compare
54c87e1 to
0a2c5ce
Compare
| - run: yarn check-dependencies | ||
|
|
||
| - name: 'Check version plans' | ||
| run: yarn nx release plan:check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nx is used for releases, so we need it to be installed -> removing artificial ci-change workflow
| @@ -1 +1,3 @@ | |||
| export { createRoot, root } from './root'; | |||
|
|
|||
| export const apiV2 = 'noop'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
3a4c74c to
55820f5
Compare
Pre-requirements
New Behaviour
migrates releases from beachball to NX Release Plans which add various needed features to our release process
dry-runmode for all release steps ( including npm publish )npm publisherrorsPublishindefinitely until registry contains all required assets that were part of the pipelineNew Release pipeline architecture:
flowchart LR subgraph Release assets['build,lint,test,type-check']-->bump-versions-->generate-changelogs-->push-to-origin end subgraph Publish build-production-assets-->npm-publish end Release-->RS RS -- yes --> Publish RS -- no --> FAIL Publish-->PS PS -- yes --> OK PS -- no --> FAIL RS@{ shape: diamond, label: "Release success?" } PS@{ shape: diamond, label: "Publish success?" } OK["pipeline success"] FAIL["pipeline failure"]TODO:
Release plans Missing features:
NX release cli issues:
releasecommand is missing--git-pushand--git-remoteavailable in sub-commands nrwl/nx#30551releasewont runnx-release-publishtarget and it's dependencies nrwl/nx#30552Dependency-Check rule issues